Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starrocks): fix starrocks coordinator incorrect try_join_all on join handle #19412

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in #16816, we used a try_join_all directly on the JoinHandle, which only returns the JoinError, while the error in the output of JoinHandle is ignored, because it is treated as Ok(Err(...)).

In this PR, we transform the future of JoinHandle to a single layer result, so that the error in join handle output will be treated as error.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Nov 18, 2024
@wenym1 wenym1 requested review from hzxa21 and xxhZs November 18, 2024 05:36
@wenym1
Copy link
Contributor Author

wenym1 commented Nov 18, 2024

Many thanks for @ly9chee to help locate the bug!

@wenym1 wenym1 added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 labels Nov 18, 2024
@wenym1 wenym1 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 88f9efa Nov 18, 2024
28 of 29 checks passed
@wenym1 wenym1 deleted the yiming/fix-starrocks-join-err branch November 18, 2024 07:26
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants